Ambiguous args with out/ref arg

[dtchepak]

Broken in 1.7. From #111 or #114?

Example from Google Group:

    [TestFixture]
    public class TestFixture
    {
        public interface ITestInterface
        {
            bool DoStuff(string input);
            bool DoStuff(string input, out string output);
        }

        [Test]
        public void Test()
        {
            string someType;
            var substitute = Substitute.For<ITestInterface>();
            substitute.DoStuff(Arg.Any<string>(), out someType).ReturnsForAnyArgs(info =>
                {
                    info[1] = "test";
                    return true;
                });
        }
    }
/*
NSubstitute.Exceptions.AmbiguousArgumentsException : Cannot determine argument specifications to use.
Please use specifications for all arguments of the same type.
   at NSubstitute.Core.Arguments.NonParamsArgumentSpecificationFactory.Create(Object argument, IParameterInfo parameterInfo, ISuppliedArgumentSpecifications suppliedArgumentSpecifications) in NonParamsArgumentSpecificationFactory.cs: line 26
   at NSubstitute.Core.Arguments.ArgumentSpecificationFactory.Create(Object argument, IParameterInfo parameterInfo, ISuppliedArgumentSpecifications suppliedArgumentSpecifications) in ArgumentSpecificationFactory.cs: line 25
*/

[dtchepak]

Fixed in 1.7.1. Thanks Alexandr!

[dabide]

The fix seems only to work with out, not with ref. http://stackoverflow.com/questions/1551761/ref-parameters-and-reflection

[alexandrnikitin]

It's not so obvious with ref variables. How to treat them? As "match any" like out arguments? How to specify exact argument? Using workaround? If so, then it's pretty easy fix. I think we need @dtchepak's input here.

[dtchepak]

@alexandrnikitin At first guess I'd match on ref value.

string x = "x";
sub.Stuff(ref x).Returns(info => { info[0] = "hi"; return true; });

sub.Stuff(x);
Assert.AreEqual("hi", x);
x = "something else";
sub.Stuff(x); // this call doesn't match the call spec, so `x` is not set to "hi"
Assert.NotEqual("hi", x); // 

Sound ok?

[alexandrnikitin]

I'm fine with it. This behavior is more comprehensible and logical than "match any".