fixes #246, #249, #253 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elnappo
force-pushed
the
check_domain_fixes
branch
from
fd0b6dd
to
ca42536
Compare
| # delete on primary | ||
| delete(fqdn) | ||
| # add host connectivity-test.<domain> with a random IP. See add() | ||
| add(fqdn, socket.inet_ntoa(struct.pack('>I', random.randint(1, 0xffffffff)))) |
There was a problem hiding this comment.
could be even 0, 0xffffffff as the ip does not really matter.
elnappo
force-pushed
the
check_domain_fixes
branch
from
ca42536
to
8b431fb
Compare
| @@ -23,6 +23,8 @@ zone nsupdate.info { | |||
| deny nsupdate.info. name www.nsupdate.info; | |||
| deny nsupdate.info. name ipv4.nsupdate.info; | |||
| deny nsupdate.info. name ipv6.nsupdate.info; | |||
| // this host is for testing if this domain is configured correctly | |||
There was a problem hiding this comment.
// this host is for testing if the nameserver is configured correctly and reachable
… DnsUpdateError and use random IP in check_domain(). The delete() was removed because after an add() the nameserver need time to process the nsupdate query. This leads to an NXDOMAIN response on current ip check in delete() thus the delete() call fails.
elnappo
force-pushed
the
check_domain_fixes
branch
from
8b431fb
to
f987fae
Compare
ThomasWaldmann
added a commit
that referenced
this pull request
Jan 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
except DnsUpdateError and use a random IP in check_domain() to prevent SameIPError.