Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate email address in registration form #375

Merged
merged 1 commit into from Oct 14, 2018
Merged

validate email address in registration form #375

merged 1 commit into from Oct 14, 2018

Conversation

ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Oct 2, 2018 •
edited

i get tons of mailer daemon emails each day, just because emails are invalid, domain has no mx, ...

fixes #284

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling a9d569e on ThomasWaldmann:validate-registration-email into 90e59c7 on nsupdate-info:master.

@coveralls
Copy link

coveralls commented Oct 2, 2018 •
edited

Coverage Status

Coverage decreased (-1.2%) to 72.767% when pulling 7dcf5a2 on ThomasWaldmann:validate-registration-email into 90e59c7 on nsupdate-info:master.

@ThomasWaldmann ThomasWaldmann mentioned this pull request Oct 3, 2018
Closed
@ThomasWaldmann ThomasWaldmann changed the title validate domain of email address in registration form, via DNS WIP: validate email address in registration form Oct 3, 2018
@ThomasWaldmann
Copy link
Member Author

rthalley/dnspython#283 makes this not work on the nsupdate.info server. :(

@ThomasWaldmann ThomasWaldmann changed the title WIP: validate email address in registration form validate email address in registration form Oct 14, 2018
@ThomasWaldmann
validate domain of email address in registration form, fixes nsupdate…
7dcf5a2 
…-info#284

- via DNS (MX, A/AAAA records)
- against blacklist with regexes

This is implemented because without it, postmasters get tons of mailer daemon
emails each day, just because emails are invalid, domain has no mx, ...
@ThomasWaldmann ThomasWaldmann merged commit bd0fa0f into nsupdate-info:master Oct 14, 2018
@ThomasWaldmann ThomasWaldmann deleted the validate-registration-email branch October 14, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement mail domain blacklist
2 participants
@ThomasWaldmann @coveralls