Update to Django 4.2 #517
Closed
Update to Django 4.2 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWaldmann
force-pushed
the
django42
branch
3 times, most recently
from
e23ce1d
to
a65b017
Compare
ThomasWaldmann
commented
Apr 12, 2023
Comment on lines
260
to
264
| class Meta(object): | ||
| unique_together = (('name', 'domain'),) | ||
| index_together = (('name', 'domain'),) | ||
| constraints = [models.constraints.UniqueConstraint(fields=['name', 'domain'], name='unique_host_domain')] | ||
| indexes = [models.Index(fields=['name', 'domain'])] | ||
| verbose_name = _('host') | ||
| verbose_name_plural = _('hosts') |
There was a problem hiding this comment.
something is wrong here. any idea, @nougad ? (see github actions CI)
*_together are deprecated in django 4.2 / soon.
ThomasWaldmann
force-pushed
the
django42
branch
from
7478a3f
to
78ac8c5
Compare
|
Looks like 4.2.1 came out May 3rd :) |
|
@jhass that's great. but someone still has to solve the issues in this PR, see above, see failing tests. |
django-admin.py is deprecated. also, it can be used instead of python manage.py and is easier for the docs.
|
superseded by #529. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still some unsolved issues, can anybody help (see below)?