rewrite socket error handling, fixes #522 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWaldmann
force-pushed
the
socket-herror
branch
from
2d8b44b
to
37a5147
Compare
socket.error is deprecated and is the same as OSError since python 3.3. Of course OSError can mean a lot of stuff, so not sure how that goes... socket.herror is for gethostbyaddr and has some documented h_error values in netdb.h (but, AFAIK, these symbols are not available via python). added a handler for h_error 0 (nsupdate-info#522), which crashed since a while. removed some unclear error values, let's see what happens.
ThomasWaldmann
force-pushed
the
socket-herror
branch
from
37a5147
to
722f76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socket.error is deprecated and is the same as OSError since python 3.3. Of course OSError can mean a lot of stuff, so not sure how that goes...
socket.herror is for gethostbyaddr and has some documented h_error values in netdb.h (but, AFAIK, these symbols are not available via python).
added a handler for h_error 0 (#522), which crashed since a while. removed some unclear error values, let's see what happens.