Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Commit

Permalink
Remove @response instance variable in QuickpayGateway.
Browse files Browse the repository at this point in the history
git-svn-id: https://activemerchant.googlecode.com/svn/trunk/active_merchant@623 6513ea26-6c20-0410-8a68-89cd7235086d
  • Loading branch information
codyfauser committed Jan 28, 2008
1 parent 8119ebd commit d31caf9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
= ActiveMerchant CHANGELOG

* Remove @response instance variable in QuickpayGateway. [cody]
* Remove @response instance variable in PsigateGateway. Don't use billing address for shipping [cody]
* Remove @response instance variable in PaypalGateway. Don't use billing address for shipping. [cody]
* Remove @response instance variable in PayflowGateway [cody]
Expand Down
14 changes: 7 additions & 7 deletions lib/active_merchant/billing/gateways/quickpay.rb
Original file line number Diff line number Diff line change
Expand Up @@ -112,17 +112,17 @@ def add_reference(post, identification)
end

def commit(action, params)
data = ssl_post URL, post_data(action, params)
@response = parse(data)
response = parse(ssl_post(URL, post_data(action, params)))

success = @response[:qpstat] == APPROVED
message = message_from(@response)

Response.new(success, message, @response,
Response.new(successful?(response), message_from(response), response,
:test => test?,
:authorization => @response[:transaction]
:authorization => response[:transaction]
)
end

def successful?(response)
response[:qpstat] == APPROVED
end

def parse(data)
response = {}
Expand Down

0 comments on commit d31caf9

Please sign in to comment.