Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlap problem #48

Closed
X-G opened this issue May 29, 2015 · 10 comments
Closed

overlap problem #48

X-G opened this issue May 29, 2015 · 10 comments

Comments

@X-G
Copy link

X-G commented May 29, 2015

Sorry about my poor English. I'm trying to report this by screenshot.
It happens when the codes are long enough and you scroll down.
qq 20150529195641

@willwhitney
Copy link
Collaborator

This is a problem with the Atom API for markers. I've opened an issue at atom/atom#6857 — I need them to fix it before I can address this, unfortunately.

@willwhitney
Copy link
Collaborator

Or rather, I could fix it for us, but at risk of breaking other packages (as I mention on that thread). I think it's unlikely that any packages depend on the exact z-index of the tab bar, so if they don't get a fix done soon I'll just do that.

@willwhitney
Copy link
Collaborator

Went ahead and did this. Shipped in v0.4.0!

@X-G
Copy link
Author

X-G commented Jun 16, 2015

Thanks Will.

@n-riesco
Copy link
Collaborator

This issue is still present in v0.7.1

@n-riesco n-riesco reopened this Mar 11, 2016
@n-riesco
Copy link
Collaborator

This comment shows the issue clearly.

@rgbkrk
Copy link
Member

rgbkrk commented Mar 11, 2016

Block decorations should be the way forward. http://blog.atom.io/2016/02/03/introducing-block-decorations.html

@n-riesco
Copy link
Collaborator

@rgbkrk I've tried the following with Atom 1.7.0-dev-7040035 and it doesn't seem to work:

$ git diff
diff --git a/lib/main.coffee b/lib/main.coffee
index 7afdb18..10b2ef0 100644
--- a/lib/main.coffee
+++ b/lib/main.coffee
@@ -159,9 +159,9 @@ module.exports = Hydrogen =
         view.statusContainer.setAttribute('style', "height: #{lineHeight}px")

         @editor.decorateMarker marker,
-            type: 'overlay'
+            type: 'block'
             item: element
-            position: 'tail'
+            position: 'after'

         @markerBubbleMap[marker.id] = view
         marker.onDidChange (event) =>
diff --git a/styles/hydrogen.less b/styles/hydrogen.less
index 5ba24fa..cd98ed4 100644
--- a/styles/hydrogen.less
+++ b/styles/hydrogen.less
@@ -5,20 +5,6 @@
 @import "ui-variables";
 @import "syntax-variables";

-// this is a hack to deal with a failing of the markers API
-// https://github.com/atom/atom/issues/6857
-.tab-bar {
-    z-index: 5;
-}
-
-.bottom{
-    z-index: 4;
-}
-
-atom-overlay.autocomplete-plus {
-  z-index: 6;
-}
-
 .hydrogen.output-bubble {
     @light-bubble-background: fadein(lighten(@syntax-background-color, 40%), 100%);
     @dark-bubble-background: fadein(lighten(@syntax-background-color, 10%), 100%);

untitled

@lgeiger
Copy link
Member

lgeiger commented Mar 15, 2016

@n-riesco if you remove this line the result should be displayed. But of course the styling will be totally messed up.

@n-riesco
Copy link
Collaborator

@lgeiger Here's how it looks like after removing position: absolute:

untitled

n-riesco added a commit to n-riesco/hydrogen that referenced this issue Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants