Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session name display in WSKernelPicker #1247

Merged
merged 1 commit into from Mar 3, 2018

Conversation

nikitakit
Copy link
Contributor

This is in response to #1245

model.notebook.path does not exist for kernels spawned from hydrogen, but model.path does.

In general, the schema for session model objects has undergone some changes in the past year or so. Once Jupyterlab and @jupyter/services get to the point of actually having a stable developer API, we can consider additional changes (such as taking advantage of the name field instead of pretending that everything is a path)

Copy link
Member

@lgeiger lgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix 👍

@lgeiger lgeiger merged commit fb02a36 into nteract:master Mar 3, 2018
@lgeiger
Copy link
Member

lgeiger commented Mar 3, 2018

In general, the schema for session model objects has undergone some changes in the past year or so. Once Jupyterlab and @jupyter/services get to the point of actually having a stable developer API, we can consider additional changes (such as taking advantage of the name field instead of pretending that everything is a path)

@jupyter/services is stable and following semantic versioning now. Unfortunately upgrading to @jupyter/services requires some changes on our side see #1162.
A great alternative is also rx-jupyter if someone is interested in looking into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants