-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zmq for everyone #1
Comments
I recommend https://github.com/mafintosh/prebuild for the binaries part, it even has a feature to upload the binaries to GitHub Releases for you |
Awesome. Do you think I should just create a |
Seems like a good idea |
Seems like I'll need Electron support in prebuild: prebuild/prebuild#61 For now I've submitted a PR to zmq relying on node-pre-gyp (JustinTulloss/zeromq.node#486), now that node-pre-gyp supports Electron directly. |
I think this can be closed now? |
Now that zmq-prebuilt exists (though not finished), yes! |
Re-opening until we fully resolve this for nteract/nteract. We made a release with a built binary for some platforms, yet it requires that you still have zmq headers installed. |
😲 |
Fix up the toolbar and cell tests.
I tested zmq on windows with nteract and can manually reproduce this error. It turns out zmq has to be built with electron headers on windows even for electron < 1.1.3 to make it work. |
and so it is, we must trudge these waters of electron builds for the future of all of us |
Status on windows: |
@lgeiger has totally demolished this issue - from incredible cross-platform work in We even have Windows builds now. 😄 😱 Closing this issue with much appreciation. |
@rgbkrk Since the fallback is now working in I didn't expect to get it working at the time of creating |
Leave a deprecation notice in zmq-static, pointing to zmq-prebuilt. You apparently stirred a little bit of buzz by creating |
Great to see some people checking it out! I'll leave a notice. |
One way to "deprecate" while being backwards compatible is to make module.exports = require('zmq-prebuilt') (while also noting they should use |
I think we can leave it as is for people who really want to keep using VS 2013. |
Ah, ok, that works. |
use es6 imports (not commonJS); styled-jsx plays better with them
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
In order to connect to any Jupyter kernel, they rely on zmq for reliable interprocess communication. The node bindings, which are quite stable (and awesome), are a bit persnickety to install on some platforms (as with anything relying on native bindings to C). In order for a developer to build, e.g., an Electron app that relies on zmq, they tend to need these items:
(optionally) libsodium for encryptionTweetNACL is built in now!Releasing multiplatform precompiled binaries for node modules is completely doable, though care has to be taken to allow users to use their local version of libzmq + libsodium as well.
If you dig through issues on zmq, you'll find quite a few about installation issues. Currently there are bundled Windows binaries in the repository for libzmq (for linking against).
The text was updated successfully, but these errors were encountered: