feat(Windows): Add windows support #903
Conversation
| @@ -4,6 +4,7 @@ | |||
| "description": ":notebook: the nteract notebook", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "postinstall": "node scripts/rebuild.js", | |||
There was a problem hiding this comment.
Is postinstall the right place for this?
There was a problem hiding this comment.
That's probably fine. prepublish is a likely candidate, but I don't know the lifecycle/order for electron-packager. If it's working, lets go with it for now. I'm assuming this doesn't run within the dist copy - anyone doing an install is in dev mode.
Current coverage is 83.74% (diff: 100%)@@ master #903 diff @@
==========================================
Files 47 47
Lines 1267 1267
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1061 1061
Misses 206 206
Partials 0 0
|
| @@ -34,6 +35,7 @@ | |||
| "dist:linux32": "npm run dist -- --platform=linux --arch=ia32", | |||
| "dist:osx": "npm run dist -- --platform=darwin --arch=x64 --icon ./static/icon.icns --extend-info=./static/extend.plist --app-category-type=public.app-category.developer-tools --app-bundle-id=io.nteract.nteract", | |||
| "dist:osx:signed": "npm run dist:osx -- --osx-sign", | |||
| "dist:win": "npm run dist -- --platform=win32 --icon ./static/icon.ico", | |||
| if (err) { | ||
| throw err; | ||
| } | ||
| }); |
There was a problem hiding this comment.
While I'm a fan of this, what are we re-doing that's already done in electron-rebuild?
There was a problem hiding this comment.
I tried electron-rebuild and it didn't work out of the box. Probably it was missing a --build-from-source flag somewhere.
There was a problem hiding this comment.
It looks like I ran into this issue: electron/rebuild#53
|
Do you think we're ready to pull the trigger on switching to |
|
If we switch to I'm OK with it, but it would be harder for new contributors. On the other side we could use the latest electron then. |
|
I summon @jdetle to the conversation since I know he both wants new Electron and is closer to the feeling that new contributors face. |
|
And one would need Python 2 for node-gyp. That said, 馃憤 for moving to |
|
Since we're actually shipping builds, at the very least it means that trial users can just roll with nteract directly and not have to build from source. My original hesitation to enforce all the build tooling setup was barriers to entry for those that are more on the frontend dev side, less astute with Jupyter. |
We still have to do the rebuild though right? |
Yes that can be done with |
|
A wild @jdetle has appeared! I have no idea what the value of zmq-static is right now, but in terms of installing additional dependencies, I think we're fine. We can always post some sort of caveat, "If you are having trouble installing dependencies for nteract, you're always welcome to ask questions in our Slack." (Of course I volunteer to help anyone having issues.) |
|
@jdetle It would mean we could use the latest electron release at the cost of building zeromq ourself. |
|
Is there a reasonable way to make |
|
I'm only asking that because of the node kernel I've been hacking on - I want to keep it relying on prebuild - it makes install so painless. |
|
@rgbkrk It looks like the This means we could rebuild |
|
I need some sort of excited emoji. |
|
It works! 馃帀 I couldn't wait to try it 馃槈. The PR will come tomorrow. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Welcome windows devs! 馃帀
Since we don't have
zmq-prebuiltfor electron on windows (yet), this will rebuilt zmq from source. Windows devs will need Visual Studio 2013 and Python 2.