feat: launch by kernelspec

[rgbkrk]

Beginning efforts to make it so we can launch by kernelspec rather than
kernelspec name. This is to enable conda environments, an embedded JS kernel,
and make it easier to do remote kernels by refactoring how we launch.

• Launch new notebook from command line
• Launch new notebook from menu
• Change kernel
• Open old notebook
• More test coverage
• Ensure notebook schema conformance

[codecov-io]

Current coverage is 91.76% (diff: 89.65%)

Merging #1264 into master will decrease coverage by 0.06%

@@             master      #1264   diff @@
==========================================
  Files            57         57          
  Lines          1482       1494    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1361       1371    +10   
- Misses          121        123     +2   
  Partials          0          0          

Powered by Codecov. Last update f10a5ed...792f20d

[rgbkrk]

This PR is excellent proof of missing tests for main. 😉

[alexandercbooth]

I'd be happy to start chipping away on some tests for main, if someone wouldn't mind giving me a little guidance on where to start.

[rgbkrk]

I'd be happy to start chipping away on some tests for main, if someone wouldn't mind giving me a little guidance on where to start.

I'm going to break so many things right now that I might as well make a testing harness for some of what's in main here.

The main thing is that much of main can be tested just like the notebook. Try to find functions that don't require the filesystem or electron APIs (there are a few I know of) and you'll be off to a start.

[jdetle]

The main thing is that

I c wut u did thar

[rgbkrk]

Ok this is now "ready". By that I mean that it's ready for me to update tests now that I have it working.

[rgbkrk]

This still fails conformance tests, I'll come back to it later.

[rgbkrk]

Rebased, going to see what likely lint errors exist now.

[rgbkrk]

Sure enough, this PR still has an issue with conformance:

$ npm run test:conformance

> nteract@0.0.15 test:conformance /Users/kylek/code/src/github.com/nteract/nteract
> node scripts/conformance.js

✅	/Users/kylek/code/src/github.com/nteract/nteract/example-notebooks/altair.ipynb
❌	/Users/kylek/code/src/github.com/nteract/nteract/example-notebooks/blah.ipynb
[ ValidationError {
    property: 'instance.metadata.kernelspec',
    message: 'requires property "display_name"',
    schema:
     { description: 'Kernel information.',
       type: 'object',
       required: [Object],
       properties: [Object] },
    instance: { name: 'python3' },
    name: 'required',
    argument: 'display_name',
    stack: 'instance.metadata.kernelspec requires property "display_name"' } ]

I'll see if I can iron that out. Otherwise, kernels are executing just fine.

[rgbkrk]

Finally finished off this branch -- the kernel info is set properly in the document now. It's very ready for review. 😄

[jdetle]

Per advice in redux-observable/redux-observable#108,

ActionsObservable.of(executeCell('id', 'source')));
  executeCellEpic(action$, store)
    .toArray()
    .subscribe(actions => {
      expect(actions).to.deep.equal([
        kernelNotConnected() // whatever action creators
      ]);
      done();
    });
});

is a more succinct pattern to follow in the future.

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.