Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all our packages should use the same babel config #1484

Closed
wants to merge 1 commit into from

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Feb 18, 2017

Spreading babel config everywhere. 🤔 I wonder if I could just place a .babelrc inside of packages/. Let me try that, don't merge me.

@codecov-io
Copy link

codecov-io commented Feb 18, 2017

Codecov Report

Merging #1484 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1484   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          41       41           
  Lines        1239     1239           
=======================================
  Hits         1138     1138           
  Misses        101      101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ccfab4...b401a91. Read the comment docs.

@rgbkrk rgbkrk closed this Feb 18, 2017
@rgbkrk rgbkrk deleted the omg-babel branch February 18, 2017 00:46
@rgbkrk
Copy link
Member Author

rgbkrk commented Feb 18, 2017

I like the approach in #1485, it lets a base setup be picked up in packages so we don't have to cargo cult it everywhere and we can still modify it for any particular package.

@lock
Copy link

lock bot commented Apr 3, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants