Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More selectors #2500

Merged
merged 5 commits into from
Feb 8, 2018
Merged

More selectors #2500

merged 5 commits into from
Feb 8, 2018

Commits on Feb 7, 2018

  1. refactor: use import * for selectors. 

    We will commonly be naming variables with the same name as the selector.
Instead of doing variable gymnastics, we can just import selectors in
a namespace.
    @theengineear
    theengineear committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    7d07b0b View commit details
    Browse the repository at this point in the history

  2. refactor: ditch the get prefix for selectors. 

    You're always *getting* with selectors, so this is a little excessive.
    @theengineear
    theengineear committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    dbe0f98 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2018

  1. Add a bunch of new selectors to core.

    @theengineear
    theengineear committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    1c95182 View commit details
    Browse the repository at this point in the history

  2. fix: clean up some duplicated imports.

    @theengineear
    theengineear committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    65bd69e View commit details
    Browse the repository at this point in the history

  3. Use selectors instead wherever possible.

    @theengineear
    theengineear committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    084764a View commit details
    Browse the repository at this point in the history