little bits of todo cleanup #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgbkrk
force-pushed
the
remove-defaults
branch
from
2b161c2
to
c8e765c
Compare
| @@ -492,10 +492,10 @@ export function deleteMetadata(field: string): DeleteMetadataFieldAction { | |||
| }; | |||
| } | |||
|
|
|||
| // TODO: we should probably remove the default here. | |||
| export function killKernel( | |||
| payload: { restarting: boolean, ref?: KernelRef } = { restarting: false } | |||
| @@ -847,10 +847,10 @@ export function shutdownReplyTimedOut(payload: { | |||
| }; | |||
| } | |||
|
|
|||
| // TODO: probably should remove default here. | |||
| export function restartKernel( | |||
| payload: { clearOutputs: boolean, ref?: KernelRef } = { clearOutputs: false } | |||
theengineear
approved these changes
Feb 28, 2018
7 tasks
|
Howdy! I'm 🔓🤖! In order to keep information timely (based on the most recent release), we want all activity to be added to either new issues or open issues and PRs. In service to that goal, I, the lock bot close inactive closed issues when they haven't had activity in 120 days. Feel free to open a new issue for related bugs and link to relevant comments from this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I know this affects things with our flow setup, I'm removing these defaults for kill and restart.