Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

little bits of todo cleanup #2611

Merged
merged 1 commit into from
Feb 28, 2018
Merged

little bits of todo cleanup #2611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/desktop/src/notebook/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export function triggerWindowRefresh(store: *, filename: string) {

export function dispatchRestartKernel(store: *) {
// TODO: provide a KernelRef
store.dispatch(actions.restartKernel());
store.dispatch(actions.restartKernel({ clearOutputs: false }));
}

export function triggerKernelRefresh(store: *, filename: string): Promise<*> {
Expand Down
16 changes: 8 additions & 8 deletions packages/core/src/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,10 +492,10 @@ export function deleteMetadata(field: string): DeleteMetadataFieldAction {
};
}

// TODO: we should probably remove the default here.
export function killKernel(
payload: { restarting: boolean, ref?: KernelRef } = { restarting: false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 thanks!

): KillKernelAction {
export function killKernel(payload: {
restarting: boolean,
ref?: KernelRef
}): KillKernelAction {
return {
type: actionTypes.KILL_KERNEL,
payload
Expand Down Expand Up @@ -847,10 +847,10 @@ export function shutdownReplyTimedOut(payload: {
};
}

// TODO: probably should remove default here.
export function restartKernel(
payload: { clearOutputs: boolean, ref?: KernelRef } = { clearOutputs: false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

): RestartKernel {
export function restartKernel(payload: {
clearOutputs: boolean,
ref?: KernelRef
}): RestartKernel {
return {
type: actionTypes.RESTART_KERNEL,
payload
Expand Down