Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nteract/web] Add notebook component and wrap up for beta and GSoC. #5257

Merged
merged 40 commits into from Sep 27, 2020

Conversation

ramantehlan
Copy link
Member

@ramantehlan ramantehlan commented Aug 11, 2020

ss

This PR is to finish adding all the tasks required to launch it as beta and wrap up the GSoC period.

UI/UX Integration

The list of components that needs to be created and added is given below, more might be added later:

  • Layout
  • BinderMenu
  • Input
  • Menu
  • Button
  • Avatar
  • Dialog
  • Landing Page
  • Auth page
  • Editor Using @nteract/editor | Later we can use @nteract/monaco-editor
  • Console
  • FileExplorer
  • Notification Using new component | Later we can use nteract legacy lib
  • Notebook rendering.

Github Integration

This PR will also allow OAuth authentication with Github, and fetch user public info.

  • Complete authentication
  • Fetch user's public info
  • Fetch public files and folders
  • List and create a fork for repo
  • Save back changes to the repo or the fork

MyBinder Integration

  • Launch MyBinder instance on start.
  • Communicate with JupyterServer. Fetch info like sessions etc.
  • Execute the command on MyBinder instance
  • Fetch content from Github and not jupyter server.
  • Save back changes done to the notebook.

@ramantehlan ramantehlan self-assigned this Aug 11, 2020
@ramantehlan ramantehlan added this to In Progress in nteract/web & nteract play Aug 11, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 11, 2020

This pull request fixes 2 alerts when merging e4920e5 into f109c9c - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 11, 2020

This pull request fixes 2 alerts when merging 9b502d8 into f109c9c - view on LGTM.com

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 13, 2020

This pull request introduces 6 alerts and fixes 2 when merging 2bfece1 into f109c9c - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class
  • 1 for Use of returnless function

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2020

This pull request introduces 6 alerts and fixes 3 when merging 30de767 into 595b72b - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2020

This pull request introduces 6 alerts and fixes 3 when merging e3df7d4 into 595b72b - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

fixed alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2020

This pull request introduces 6 alerts and fixes 3 when merging 1ed4ca2 into 595b72b - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

fixed alerts:

  • 3 for Unused variable, import, function or class

@ramantehlan ramantehlan changed the title [nteract/web] Connecting to Binder [nteract/web] Add notebook component and wrap up for beta and GSoC. Aug 20, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2020

This pull request introduces 5 alerts and fixes 5 when merging dc7d2cf into 595b72b - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Use of returnless function

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2020

This pull request introduces 5 alerts and fixes 5 when merging ac96384 into 595b72b - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Use of returnless function

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2020

This pull request introduces 5 alerts and fixes 5 when merging 29ffa0b into 595b72b - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Use of returnless function

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2020

This pull request introduces 5 alerts and fixes 5 when merging 499a216 into 595b72b - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Use of returnless function

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 4, 2020

This pull request introduces 6 alerts and fixes 5 when merging 637a709 into b87e929 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable
  • 1 for Use of returnless function

fixed alerts:

  • 5 for Unused variable, import, function or class

@ramantehlan ramantehlan requested review from captainsafia and CrystallineCat and removed request for captainsafia September 4, 2020 11:57
@ramantehlan ramantehlan marked this pull request as ready for review September 4, 2020 11:58
@lgtm-com
Copy link

lgtm-com bot commented Sep 4, 2020

This pull request introduces 10 alerts and fixes 5 when merging 15fa6e4 into b87e929 - view on LGTM.com

new alerts:

  • 8 for Syntax error
  • 1 for Useless assignment to local variable
  • 1 for Use of returnless function

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 4, 2020

This pull request introduces 6 alerts and fixes 5 when merging f61edcf into b87e929 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable
  • 1 for Use of returnless function

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 4, 2020

This pull request introduces 3 alerts and fixes 5 when merging 687a574 into b87e929 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 4, 2020

This pull request introduces 1 alert and fixes 5 when merging c1731b1 into b87e929 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 5 for Unused variable, import, function or class

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments inline.

I tried to run a cell with these commits and ran into some issues. The Binder instance was successfully connected.

I captured some error traces from the run below.

Screen Shot 2020-09-06 at 5 47 31 PM

Screen Shot 2020-09-06 at 5 47 21 PM

packages/stateful-components/src/cells/cells.tsx Outdated Show resolved Hide resolved
applications/web/components/BinderMenu.tsx Outdated Show resolved Hide resolved
applications/web/components/Input.tsx Outdated Show resolved Hide resolved
applications/web/pages/p/index.tsx Outdated Show resolved Hide resolved
applications/web/pages/p/index.tsx Outdated Show resolved Hide resolved
applications/web/pages/p/index.tsx Outdated Show resolved Hide resolved
applications/web/pages/p/index.tsx Outdated Show resolved Hide resolved
applications/web/pages/p/index.tsx Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Sep 8, 2020

This pull request introduces 1 alert and fixes 5 when merging 7900efd into b09cfb5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request introduces 1 alert and fixes 5 when merging 7f7a8d7 into b09cfb5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request introduces 2 alerts and fixes 5 when merging dd7c305 into b09cfb5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 5 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request introduces 2 alerts and fixes 5 when merging ee80a60 into b09cfb5 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 5 for Unused variable, import, function or class

@ramantehlan
Copy link
Member Author

Thank you for the review @captainsafia.

While trying to reproduce the cell not running issue, I observed that It happens only when we open a notebook before it is connected to the server, so it doesn't work even after it gets connected to the server. If we reload the page, it starts to work again. I will open an issue for the same.

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging now so we can iterate in smaller PRs.

@captainsafia captainsafia merged commit 428f0f4 into nteract:main Sep 27, 2020
nteract/web & nteract play automation moved this from In Progress to Done Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants