New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nteract/web] Add notebook component and wrap up for beta and GSoC. #5257
Conversation
This pull request fixes 2 alerts when merging e4920e5 into f109c9c - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging 9b502d8 into f109c9c - view on LGTM.com fixed alerts:
|
This pull request introduces 6 alerts and fixes 2 when merging 2bfece1 into f109c9c - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 6 alerts and fixes 3 when merging 30de767 into 595b72b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 6 alerts and fixes 3 when merging e3df7d4 into 595b72b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 6 alerts and fixes 3 when merging 1ed4ca2 into 595b72b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 5 alerts and fixes 5 when merging dc7d2cf into 595b72b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 5 alerts and fixes 5 when merging ac96384 into 595b72b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 5 alerts and fixes 5 when merging 29ffa0b into 595b72b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 5 alerts and fixes 5 when merging 499a216 into 595b72b - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 6 alerts and fixes 5 when merging 637a709 into b87e929 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 10 alerts and fixes 5 when merging 15fa6e4 into b87e929 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 6 alerts and fixes 5 when merging f61edcf into b87e929 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 3 alerts and fixes 5 when merging 687a574 into b87e929 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 5 when merging c1731b1 into b87e929 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request introduces 1 alert and fixes 5 when merging 7900efd into b09cfb5 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 5 when merging 7f7a8d7 into b09cfb5 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 5 when merging dd7c305 into b09cfb5 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 5 when merging ee80a60 into b09cfb5 - view on LGTM.com new alerts:
fixed alerts:
|
Thank you for the review @captainsafia. While trying to reproduce the cell not running issue, I observed that It happens only when we open a notebook before it is connected to the server, so it doesn't work even after it gets connected to the server. If we reload the page, it starts to work again. I will open an issue for the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging now so we can iterate in smaller PRs.
This PR is to finish adding all the tasks required to launch it as beta and wrap up the GSoC period.
UI/UX Integration
The list of components that needs to be created and added is given below, more might be added later:
Using @nteract/editor | Later we can use @nteract/monaco-editor
Using new component | Later we can use nteract legacy lib
Github Integration
This PR will also allow OAuth authentication with Github, and fetch user public info.
MyBinder Integration