Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back strip_color and remove ANSI color codes from exception traceback #791

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

mbektas
Copy link
Contributor

@mbektas mbektas commented Apr 3, 2024

#681 removed ansiwrap dependency and strip_color used to clean up ANSI color codes from exception outputs. That is a breaking change and preventing us to use the latest papermill version.

This PR brings in only the strip_color implementation from ansiwrap package and uses it to remove ANSI color codes as the versions <= 2.4.0 did.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #791 (0409031) into main (cb2eb37) will decrease coverage by 0.25%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 0409031 differs from pull request most recent head 7a6dc45. Consider uploading reports for the commit 7a6dc45 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   91.54%   91.29%   -0.25%     
==========================================
  Files          17       17              
  Lines        1621     1632      +11     
==========================================
+ Hits         1484     1490       +6     
- Misses        137      142       +5     

@mbektas
Copy link
Contributor Author

mbektas commented Apr 3, 2024

@MSeal would you be able to check out this one as well before the next release? thanks!

papermill/exceptions.py Outdated Show resolved Hide resolved
@MSeal MSeal merged commit 0f48299 into nteract:main Apr 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants