Remove use of ansiwrap #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSeal
approved these changes
Oct 4, 2022
This was referenced Oct 23, 2023
|
It would be great to get this fix in a release as, now that Python 3.12 is released, this is causing issues for any packages depending on |
5 tasks
|
Got it, alright I can prepare a release of papermill to account for recent python changes. There's been a backlog of issues / PRs that will need to be a put into a fixed release build. |
|
On the |
|
Working through some other packaging issues, but will have a 3.12 build out once those are solved |
|
@dhirschfeld 2.5.0 is released to PyPI now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes use of ansiwrap in the package for the reasons in #680