Options defaults

[rgbkrk]

Spawn options are now folded into a set of default options, using Object.assign
(not a full merge).

Note: this is a breaking change, particularly for Hydrogen which was providing
"loose" stdout and stderr as notification messages in Atom (I love having this
when I'm working with Spark in Hydrogen).

Fixes #24

---

Check out commit ce657d3, as the first commit is primarily there to bring us inline with the rest of our code bases (using prettier).

[williamstein]

+1

Note: this is a breaking change, particularly for Hydrogen which was providing "loose" stdout and stderr as notification messages in Atom (I love having this when I'm working with Spark in Hydrogen).

Yes, that would be really nice to do as well of course. The thing to not do is nothing at all, which results in blocked stdout...

[williamstein]

Note: this is a breaking change

Is it a breaking change for me, who is using:

require('spawnteract').launch(@name, {detached: true, stdio:'ignore'})

[rgbkrk]

Note: this is a breaking change, particularly for Hydrogen which was providing "loose" stdout and stderr as notification messages in Atom (I love having this when I'm working with Spark in Hydrogen).

Yes, that would be really nice to do as well of course. The thing to not do is nothing at all, which results in blocked stdout...

If you want to only block stdin from the kernel process (yet not stdin on the channels):

stdio: ['ignore', 'pipe', 'pipe']

Then stderr and stdout will be piped through. That's likely what we'll switch it to for Hydrogen.

[rgbkrk]

Is it a breaking change for me, who is using:

require('spawnteract').launch(@name, {detached: true, stdio:'ignore'})

No, your options get folded in since you're overriding the defaults here.

> defaultSpawnOptions = { stdio: "ignore" }
Object {stdio: "ignore"}
> Object.assign({}, defaultSpawnOptions, { detached: true, stdio:'ignore' })
Object {stdio: "ignore", detached: true}

[rgbkrk]

Annnnnd now this passes. I kept changing the .travis.yml until I could get the python2 kernel installed.

[lgeiger]

LGTM 👍

Thanks for fixing CI 💚

[rgbkrk]

Cool, I'll ship this.

[rgbkrk]

Unless there's something else people want to get in, we'll have to call this a major release since it changes the defaults (if user's weren't setting it -- Hydrogen for example).

[rgbkrk]

v3.0.0 is out!