Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service container #208

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Service container #208

merged 5 commits into from
Jun 14, 2023

Conversation

fafhrd91
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 87.05% and project coverage change: -0.42 ⚠️

Comparison is base (a35535d) 90.78% compared to head (07b8510) 90.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   90.78%   90.36%   -0.42%     
==========================================
  Files         188      189       +1     
  Lines       30586    30848     +262     
==========================================
+ Hits        27766    27876     +110     
- Misses       2820     2972     +152     
Impacted Files Coverage Δ
ntex-service/src/boxed.rs 0.00% <0.00%> (-93.88%) ⬇️
ntex-service/src/map_config.rs 96.36% <ø> (ø)
ntex-service/src/map_init_err.rs 100.00% <ø> (ø)
ntex-service/src/lib.rs 58.88% <41.17%> (-18.04%) ⬇️
ntex-service/src/ctx.rs 91.22% <91.22%> (ø)
ntex-service/src/and_then.rs 93.96% <100.00%> (-0.38%) ⬇️
ntex-service/src/apply.rs 98.07% <100.00%> (+0.25%) ⬆️
ntex-service/src/fn_service.rs 97.22% <100.00%> (-2.78%) ⬇️
ntex-service/src/fn_shutdown.rs 97.36% <100.00%> (+0.22%) ⬆️
ntex-service/src/map.rs 96.47% <100.00%> (-1.00%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fafhrd91 fafhrd91 changed the base branch from master to ntex-0.7 June 14, 2023 13:07
@fafhrd91 fafhrd91 merged commit b7128b7 into ntex-0.7 Jun 14, 2023
20 checks passed
@fafhrd91 fafhrd91 deleted the service-container branch June 14, 2023 13:09
fafhrd91 added a commit that referenced this pull request Jun 15, 2023
* Enforce service readiness during call
* Introduce service sharable readiness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant