fix multi ctrlc handlers set in win. #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fafhrd91
reviewed
Mar 29, 2024
| use std::{cell::RefCell, thread}; | ||
|
|
||
| use ntex_rt::System; | ||
|
|
||
| use crate::server::Server; | ||
|
|
||
| static CTRL_C_HANDLER_SET: AtomicBool = AtomicBool::new(false); |
There was a problem hiding this comment.
could you mark it with #[cfg(target_family = "windows")]
There was a problem hiding this comment.
I found this fix can't stop the ntex-server normally. I need some time to find a other way. And I will add #[cfg(target_family = "windows")]
There was a problem hiding this comment.
you should store System in global before checking for var and use it instead of System::current()
There was a problem hiding this comment.
you should store System in global before checking for var and use it instead of System::current()
I'm not very good at reading all this complex runtime management code, I'm afraid I need someone who knows more about ntex to fix this problem 😳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #322