-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs&&bufey-next):fix defined in MessageMixin.js. #124
chore(docs&&bufey-next):fix defined in MessageMixin.js. #124
Conversation
✅ Deploy Preview for buefy-nextdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM✨ Please wait for @kikuomax to review this PR before pushing to MigrateToLerna
- Component works exactly like https://buefy.org
-
Netlify
Builds ⚙ - Code looks clean ✌
@zhanghengxin @wesdevpro This PR introduces an unexpected progress bar on every component using |
@zhanghengxin @wesdevpro The item on the project board is related to buefy#3855 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhanghengxin Here is the context of how |
I am currently debugging locally and have some development-related questions. At fix/draft-form-migrateToLerna First question: I am using the command "npx lerna run dev --scope=docs" to run the documentation and observe the behavior of the components. However, I noticed that when I make changes in the code, I am unable to see the updates in real-time in the docs project. Do I need to manually connect to the local component project to resolve this? Second question: Is there a direct method to debug the component project? I noticed that when I directly run the "npm run dev" command in the buefy-next project, it requires many dependencies to be installed. Is buefy-next currently runnable without any additional steps? I would appreciate some guidance on these matters. |
And for the answer.
|
30b3bdb
to
8042c9c
Compare
Due to my recent commit (1b80898), you have to build
You need to run |
@kikuomax |
@zhanghengxin Thanks for your analysis. I understood that his point was introduction of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but could you amend the last commit message? As "WIP" does not make sense.
@zhanghengxin Sorry, you do not have to do this. It should not matter as long as we squash merge your PR.
ooo,Is there anything else i need to do before squashing and merging ? |
@zhanghengxin We are good to go! |
* chore(docs&&bufey-next):fix defined in MessageMixin.js. https://github.com/orgs/ntohq/projects/12/views/1?pane=issue&itemId=32679252
https://github.com/orgs/ntohq/projects/12/views/1?pane=issue&itemId=32679252
fixed #123
Fixed buefy#3855
Fixed https://github.com/orgs/ntohq/projects/12/views/1?pane=issue&itemId=32679252
Proposed Changes