Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lib): replace snapshots affected by CompatFallthroughMixin #223

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

kikuomax
Copy link
Collaborator

@kikuomax kikuomax commented Apr 3, 2024

Fixes #

Finally ends #16.

Proposed Changes

  • Replace spec snapshots affected by the introduction of the CompatFallthroughMixin mixin

Some spec snapshots were affected by introduction of the
`compat-fallthrough` prop by `Input` or `Autocomplete`; the
`compat-fallthrough` prop appeared on the underlying stubbed components.
However, `Input` and `Autocomplete` later introduced the
`CompatFallthroughMixin` mixin to reduce the duplicate code. Since
stubbed components won't bear props in mixins, the affected snapshots no
longer contain the `compat-fallthrough` prop on the stubs.
@kikuomax kikuomax requested a review from wesdevpro April 3, 2024 22:19
Copy link

@wesdevpro wesdevpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kikuomax kikuomax merged commit e016e37 into ntohq:dev Apr 4, 2024
3 checks passed
@kikuomax kikuomax deleted the replace-outdated-snapshots branch April 4, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue Compat: deprecation INSTANCE_ATTRS_CLASS_STYLE
2 participants