Set Modal's Event Prop's Default Value #240

wesdevpro · 2024-04-29T16:48:50Z

Fixes #182

Proposed Changes

As a work around to the warning in Warning appears for programmatically opened Modal #182 by default set the Modal's event prop to an empty object.

wesdevpro · 2024-04-29T17:10:30Z

@kikuomax This issues was solved after gathering an understanding of the following eslint rule https://eslint.vuejs.org/rules/require-valid-default-prop. This PR is now ready for review as all tests/build have passed.

kikuomax

Thanks! I confirmed no warning appeared after programmatically opened a modal on the Modal doc page.

chore: set the Modal's events prop default to be an empty object

8bbfa55

wesdevpro added this to the v0.1.4 milestone Apr 29, 2024

wesdevpro requested a review from kikuomax April 29, 2024 16:48

wesdevpro self-assigned this Apr 29, 2024

wesdevpro changed the title ~~chore: set the Modal's events prop default to be an empty object~~ Set Modal's Event Prop's Default Value Apr 29, 2024

fix: set event props default value through a factory function

376363d

Source: https://eslint.vuejs.org/rules/require-valid-default-prop

kikuomax approved these changes May 6, 2024

View reviewed changes

kikuomax merged commit 21d192a into dev May 6, 2024
3 checks passed

kikuomax deleted the UpdateDefault branch May 6, 2024 22:13