build: respect environment options more #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ax_pthread.m4 to the latest version from the autoconf-archive project. Signed-off-by: Sam James <sam@gentoo.org>
It's necessary to be able to override choice of AR/CC/RANLIB and other toolchain variables/tools for cross-compilation, testing with other toolchains, and to ensure the compiler chosen by the user is actually used for the build. Previously, GNU_PREFIX was kind-of used for this but this isn't a standard variable (at all) and it wasn't applied consistently anyway. We now use the standard autoconf mechanisms for finding these tools. (RANLIB is already covered by LT_INIT.) Signed-off-by: Sam James <sam@gentoo.org>
This ensures that parallel make works correctly, as otherwise, a fresh make job will be started without the jobserver fd, and hence not know about its parent, forcing -j1.
- CPPFLAGS is for the C preprocessor (usually for setting defines) - LDFLAGS should be placed before objects for certain flags to work (e.g. -Wl,--as-needed) Signed-off-by: Sam James <sam@gentoo.org>
|
Kudos, SonarCloud Quality Gate passed!
|
|
I would love to be able to build nDPI out-of-source which is, unfortunately, impossible at the moment. I've tried to improve nDPI's build system (PR #1163), but those patches weren't merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m4/ax_pthread.m4(standard sync from autoconf-archive)AR,CC,RANLIB,CPPFLAGS,LDFLAGS(this is particularly helpful for downstreams)$(MAKE)consistently for (very slightly) better parallel builds/installsIn addition to being able to easily use e.g. Clang for testing now, it should be easier to test with different
LDFLAGS(e.g. different-fuse-ld=or-Wl,--as-needed).I'd also like to say thanks for the configure.seed->configure.ac change (cf931fd) - it's helped a lot for us downstream in Gentoo.
If build system changes are welcome, please let me know, and I may make some further modernisation changes in future if that's something you're interested in?