Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MPEG-DASH dissector. Fixes #1223. #1555

Merged
merged 1 commit into from
May 29, 2022

Conversation

utoni
Copy link
Collaborator

@utoni utoni commented May 26, 2022

  • Improved HTTP POST detection
  • Refactored subprotocol detection

Signed-off-by: lns matzeton@googlemail.com

@utoni
Copy link
Collaborator Author

utoni commented May 26, 2022

Subprotocol handling for HTTP is weird..
Most of the time HTTP is a master protocol, but in some rare cases it is an app protocol.

@utoni utoni force-pushed the add/mpegdash-and-subproto-handling branch from 21cec4d to e0790bd Compare May 27, 2022 14:51
src/lib/ndpi_main.c Show resolved Hide resolved
src/lib/protocols/mpegdash.c Outdated Show resolved Hide resolved
 * Improved HTTP POST detection
 * Refactored subprotocol detection

Signed-off-by: lns <matzeton@googlemail.com>
@utoni utoni force-pushed the add/mpegdash-and-subproto-handling branch from e0790bd to 0034882 Compare May 27, 2022 15:59
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IvanNardi IvanNardi merged commit 33f9729 into ntop:dev May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add signature to identify Mpeg-DASH(Dynamic Adaptive Streaming over HTTP) application
2 participants