Detect SMTPs w/ STARTTLS as TLS and dissect client/server hello. Fixe… #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utoni
force-pushed
the
improved/smtp-starttls
branch
from
345fba8
to
9e80568
Compare
utoni
force-pushed
the
improved/smtp-starttls
branch
from
9e80568
to
25b108f
Compare
…ntop#1630. * FTP needs to get updated as well as it has similiar STARTTLS semantics -> follow-up Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
utoni
force-pushed
the
improved/smtp-starttls
branch
from
25b108f
to
82d07eb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looks good as a solution. Not sure if TLS.Google is better than SMPTS.Google, this is my only concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s #1630.
// not a perfect solution, but sufficient to fix #1630
Signed-off-by: Toni Uhlig matzeton@googlemail.com