Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Yandex services detection #1882

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Add Yandex services detection #1882

merged 4 commits into from
Feb 9, 2023

Conversation

0xA50C1A1
Copy link
Contributor

Yandex services are quite popular in Eastern Europe, so I think it would be good to have their detection support in nDPI.

@IvanNardi
Copy link
Collaborator

Everything seems fine. Just two notes:

  1. could you please:
  • merge all these traces into one (called yandex.pcpang) and push only this one? You can try using mergecap
  • while doing the previous point, please keep only the first ~20/25 pkts for sessions (i.e. just a little after the TLS handshake ends) The idea is to have small(er) pcap in the repository, with only the "interesting" stuff (for a simple TLS matching , that means only TCP handshake + TLS handshake)
  1. Update the ASN list:
  • AS44534, AS207207, AS202611, AS13238 --> NDPI_PROTOCOL_YANDEX
  • AS210656, AS200350 --> NDPI_PROTOCOL_YANDEX_CLOUD

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@0xA50C1A1
Copy link
Contributor Author

0xA50C1A1 commented Feb 6, 2023 •
edited

@IvanNardi Thanks for the review, I've fixed it.

@IvanNardi IvanNardi merged commit ba4e145 into ntop:dev Feb 9, 2023
@IvanNardi
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNardi IvanNardi IvanNardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xA50C1A1 @IvanNardi