Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All protocols should be excluded sooner or later #1969

Merged
merged 1 commit into from
May 10, 2023
Merged

All protocols should be excluded sooner or later #1969

merged 1 commit into from
May 10, 2023

Conversation

IvanNardi
Copy link
Collaborator

For a lot of protocols, reduce the number of packets after which the protocols dissector gives up.
The values are quite arbitary, tring to not impact on classification

@IvanNardi
All protocols should be excluded sooner or later
35341f0 
For a lot of protocols, reduce the number of packets after which the
protocols dissector gives up.
The values are quite arbitary, tring to not impact on classification
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

utoni
utoni approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has hopefully no impact on the classification for real-time traffic. :)

@IvanNardi
Copy link
Collaborator Author

I have been running that code for a while now, without any specific issues.
But I must admit that most of these protocols are not really so used/common on the networks I have access to

@IvanNardi IvanNardi merged commit 31d23ae into ntop:dev May 10, 2023
33 checks passed
@IvanNardi IvanNardi deleted the all-protocols-should-be-excluded-sooner-or-later branch May 10, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utoni utoni utoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvanNardi @utoni