added feature to extract filename from http attachment #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanNardi
requested changes
Jul 7, 2023
There was a problem hiding this comment.
Hi @ChiaraMaggi, thanks for your contribution.
Unfortunately, as you can see from the CI results, there are multiple issues...
Let's start try fixing the compilation
- in
src/include/ndpi_typedefs.hreplace 952 with 960. You can test it yourself runningmake checkin your machine
Some other comments below:
IvanNardi
reviewed
Jul 7, 2023
IvanNardi
reviewed
Jul 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
IvanNardi
approved these changes
Jul 11, 2023
lucaderi
reviewed
Jul 11, 2023
| flow->http.filename = strncpy(flow->http.filename, (char*)packet->content_disposition_line.ptr+attachment_len, filename_len); | ||
| flow->http.filename[filename_len] = '\0'; | ||
| if(flow->http.filename != NULL){ | ||
| flow->http.filename = strncpy(flow->http.filename, (char*)packet->content_disposition_line.ptr+attachment_len, filename_len); |
lucaderi
reviewed
Jul 11, 2023
| flow->http.filename[filename_len-2] = '\0'; | ||
| flow->http.filename = ndpi_malloc(filename_len-1); | ||
| if(flow->http.filename != NULL){ | ||
| flow->http.filename = strncpy(flow->http.filename, (char*)packet->content_disposition_line.ptr+attachment_len+1, filename_len-2); |
lucaderi
reviewed
Jul 11, 2023
| flow->http.filename = strncpy(flow->http.filename, (char*)packet->content_disposition_line.ptr+attachment_len+1, filename_len-1); | ||
| flow->http.filename[filename_len-1] = '\0'; | ||
| if(flow->http.filename != NULL){ | ||
| flow->http.filename = strncpy(flow->http.filename, (char*)packet->content_disposition_line.ptr+attachment_len+1, filename_len-1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.