Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: extend fuzzing coverage #2040

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fuzz: extend fuzzing coverage #2040

merged 1 commit into from
Jul 11, 2023

Conversation

IvanNardi
Copy link
Collaborator

Some notes:

  • libinjection: according to XSS vs SQLI: NULL bytes libinjection/libinjection#44, it seems NULL characters are valid in the input string;
  • RTP: rtp_get_stream_type() is called only for RTP packets; if you want to tell RTP from RTCP you should use is_rtp_or_rtcp();
  • TLS: unnecessary check; we already make the same check just above, at the beginning of the while loop

Some notes:
* libinjection: according to libinjection/libinjection#44,
it seems NULL characters are valid in the input string;
* RTP: `rtp_get_stream_type()` is called only for RTP packets; if you
want to tell RTP from RTCP you should use `is_rtp_or_rtcp()`;
* TLS: unnecessary check; we already make the same check just above, at
the beginning of the `while` loop
@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@utoni utoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kudos

@utoni utoni merged commit 950f5cc into ntop:dev Jul 11, 2023
33 checks passed
@IvanNardi IvanNardi deleted the oss-fuzz-coverage branch July 11, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants