Correct the include file path in -I CFLAGS argument. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib/Makefile.in install headers into ${prefix}/include/ndpi,
but the shipped libndpi.pc.in specifies a different path. Therefore
anything trying to build using $(pkg-config --cflags libndpi) will
fail to find the nDPI headers.
This patch simply makes libndpi.pc.in agree with src/lib/Makefile.in.
|
In Makefile.in I see Why is your patch required? |
|
Oh, I worded that poorly. The problem is not that src/lib/Makefile.in is wrong about includedir, the problem is that libndpi.pc.in is wrong - does not agree with Makefile.in. This patch fixes libndpi.pc.in. |
|
This is already present in the dev branch. See commit d31a29b. Maybe it should be cherry picked to stable? |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/lib/Makefile.in install headers into ${prefix}/include/ndpi,
but the shipped libndpi.pc.in specifies a different path. Therefore
anything trying to build using $(pkg-config --cflags libndpi) will
fail to find the nDPI headers.
This patch simply makes libndpi.pc.in agree with src/lib/Makefile.in.