Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass arbitrary attributes to skin #35

Closed
dvc94ch opened this issue Jan 10, 2018 · 2 comments
Closed

pass arbitrary attributes to skin #35

dvc94ch opened this issue Jan 10, 2018 · 2 comments

Comments

@dvc94ch
Copy link
Contributor

dvc94ch commented Jan 10, 2018

Setting classes on symbols would be great. This means that only one diode or transistor symbol is required.
The diode skin would look like this:

<g s:type="diode" s:width="20" s:height="50" transform="translate(75,280)">
   <s:alias val="d"/>
   <path d="M0,15 H20 L10,35 Z M0,35 H20" class="symbol"/>
   <path d="M10,0 V15 M10,35 V50" class="connect"/>
   <!-- schottky -->
   <path s:attr="schottky" d="M0,35 V40 M20,35 V30" class="symbol"/>
   <g s:x="10" s:y="0" s:pid="+"/>
   <g s:x="10" s:y="50" s:pid="-"/>
</g>
@dvc94ch dvc94ch mentioned this issue Jan 30, 2018
@nturley
Copy link
Owner

nturley commented Mar 22, 2019

Doesn't this already work? Is this not needed now that #38 has gone in?

@nturley
Copy link
Owner

nturley commented Apr 20, 2019

I think this is done now. So I'm going to close it for now.

@nturley nturley closed this as completed Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants