-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skin format #38
Skin format #38
Conversation
Fixed eslint errors and update the examples. Updated the netlistsvg generated output using the qeda svg skin generator. @nturley thoughts? |
Qeda PR was merged, waiting on this one... |
sorry this took a while. It looks good. |
There's a lot of stuff in here and I want to make sure I understand all of it.
Do those sound correct? |
So having the ability to adding reference and values to resistors, capacitors etc wasn't actually added to the skins with this PR? |
@nturley sorry for the late reply! I hadn't seen your comment. That sounds correct. In addition to tagging lateral ports it makes port direction unnecessary on all elements except generic. |
Adds the following attributes to skin format:
s:attribute="ref|name"
can be set on texts:position="top|bottom|left|right"
can be set on pinss:generic="body"
can be set on rectsCloses #34
Relates-to #18
Uses qeda to generate skin file and therefore makes #35, #17, #33 unnecessary.
qeda/qeda#47