Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skin format #38

Merged
merged 6 commits into from
Feb 3, 2018
Merged

Skin format #38

merged 6 commits into from
Feb 3, 2018

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Jan 30, 2018

Adds the following attributes to skin format:

  • s:attribute="ref|name" can be set on text
  • s:position="top|bottom|left|right" can be set on pins
  • s:generic="body" can be set on rects

Closes #34
Relates-to #18

Uses qeda to generate skin file and therefore makes #35, #17, #33 unnecessary.
qeda/qeda#47

screenshot from 2018-01-31 18-21-46

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Feb 1, 2018

Fixed eslint errors and update the examples. Updated the netlistsvg generated output using the qeda svg skin generator. @nturley thoughts?

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Feb 2, 2018

Qeda PR was merged, waiting on this one...

@nturley
Copy link
Owner

nturley commented Feb 3, 2018

sorry this took a while. It looks good.

@nturley nturley merged commit c3d338e into nturley:master Feb 3, 2018
@nturley
Copy link
Owner

nturley commented Feb 3, 2018

There's a lot of stuff in here and I want to make sure I understand all of it.

  • s:generic=body means that the size can be overridden by the netlist?
  • s:position=top|bottom|left|right| is an alternative way to tag lateral ports?
  • s:attribute=ref means that the text is sourced from the node key?
  • s:attribute=name means that the text is sourced from the netlist?

Do those sound correct?

@kasbah
Copy link
Contributor

kasbah commented May 26, 2018

So having the ability to adding reference and values to resistors, capacitors etc wasn't actually added to the skins with this PR?

@dvc94ch
Copy link
Contributor Author

dvc94ch commented May 26, 2018

@nturley sorry for the late reply! I hadn't seen your comment.

That sounds correct. In addition to tagging lateral ports it makes port direction unnecessary on all elements except generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants