Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robin #27

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Robin #27

wants to merge 26 commits into from

Conversation

Robinyyds
Copy link
Collaborator

完善了一下格式(开溜

@Robinyyds Robinyyds closed this Jun 22, 2022
@Robinyyds Robinyyds reopened this Jun 22, 2022
Copy link
Member

@bismarckkk bismarckkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还存在以下问题,请注意修复:

  1. 没有实现通过不同的req注销的功能
  2. 普通接收功能可能存在问题
  3. 一些格式上的问题

xuluomin/client/CMakeLists.txt Outdated Show resolved Hide resolved
xuluomin/client/src/client_node.cpp Outdated Show resolved Hide resolved
xuluomin/client/src/client_node.cpp Outdated Show resolved Hide resolved
xuluomin/server/src/sever_node.cpp Outdated Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Outdated Show resolved Hide resolved
xuluomin/src/server/src/server.cpp Outdated Show resolved Hide resolved
xuluomin/src/server/src/server.cpp Outdated Show resolved Hide resolved
xuluomin/src/server/src/server.cpp Show resolved Hide resolved
@Robinyyds Robinyyds closed this Jul 3, 2022
@Robinyyds Robinyyds reopened this Jul 3, 2022
xuluomin/src/server/src/server.cpp Outdated Show resolved Hide resolved
xuluomin/src/server/src/server.cpp Outdated Show resolved Hide resolved
Copy link
Member

@bismarckkk bismarckkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 查看群内共性问题
  • 查看群内共性问题
  • 查看群内共性问题

xuluomin/src/client/msg/time.msg Outdated Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Outdated Show resolved Hide resolved
xuluomin/src/client/src/client.cpp Show resolved Hide resolved
xuluomin/src/server/CMakeLists.txt Outdated Show resolved Hide resolved
xuluomin/src/server/src/server.cpp Outdated Show resolved Hide resolved
xuluomin/src/server/src/server.cpp Show resolved Hide resolved
//input the name

// 初始化ROS节点
ros::init(argc, argv, "client",ros::init_options::AnonymousName);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Missing space after , [whitespace/comma] [3]

xuluomin/src/server/src/server.cpp Show resolved Hide resolved

server_subscribers.clear();
response.response = 20;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants