Linshuo #41
Linshuo #41
Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
cpplint
Linshuo/server/cmake-build-debug/CMakeFiles/3.22.3/CompilerIdCXX/CMakeCXXCompilerId.cpp|710| Missing space after , [whitespace/comma] [3]
Linshuo/server/src/server.cpp|8| Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Linshuo/server/src/server.cpp|18| Lines should be <= 80 characters long [whitespace/line_length] [2]
Linshuo/server/src/server.cpp|22| Lines should be <= 80 characters long [whitespace/line_length] [2]
Linshuo/server/src/server.cpp|24| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Linshuo/server/src/server.cpp|29| Lines should be <= 80 characters long [whitespace/line_length] [2]
Linshuo/server/src/server.cpp|44| Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
Linshuo/server/src/server.cpp|63| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Linshuo/server/src/server.cpp|66| Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
| #include <unistd.h> | ||
|
|
||
| #include <ctime> | ||
| #include <chrono> |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
is an unapproved C++11 header. [build/c++11] [5]
| #include <cstring> | ||
| #include <iostream> | ||
|
|
||
| using namespace std; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
| #include <iostream> | ||
|
|
||
| using namespace std; | ||
| using namespace std::chrono; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
| system_clock::time_point today = system_clock::now(); | ||
| time_t tm = system_clock::to_time_t(today); | ||
|
|
||
| time_msg.timer = ctime(&tm); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Consider using ctime_r(...) instead of ctime(...) for improved thread safety. [runtime/threadsafe_fn] [2]
| } | ||
|
|
||
|
|
||
| void interrupt_handler(int x) |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
| #ifdef COMPILER_VERSION_INTERNAL | ||
| char const info_version_internal[] = { | ||
| 'I', 'N', 'F', 'O', ':', | ||
| 'c','o','m','p','i','l','e','r','_','v','e','r','s','i','o','n','_', |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing space after , [whitespace/comma] [3]
| char const info_version_internal[] = { | ||
| 'I', 'N', 'F', 'O', ':', | ||
| 'c','o','m','p','i','l','e','r','_','v','e','r','s','i','o','n','_', | ||
| 'i','n','t','e','r','n','a','l','[', |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing space after , [whitespace/comma] [3]
| 'I', 'N', 'F', 'O', ':', | ||
| 'c','o','m','p','i','l','e','r','_','v','e','r','s','i','o','n','_', | ||
| 'i','n','t','e','r','n','a','l','[', | ||
| COMPILER_VERSION_INTERNAL,']','\0'}; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing space after , [whitespace/comma] [3]
| 'i','n','t','e','r','n','a','l','[', | ||
| COMPILER_VERSION_INTERNAL,']','\0'}; | ||
| #elif defined(COMPILER_VERSION_INTERNAL_STR) | ||
| char const* info_version_internal = "INFO" ":" "compiler_version_internal[" COMPILER_VERSION_INTERNAL_STR "]"; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Lines should be <= 80 characters long [whitespace/line_length] [2]
| #ifdef SIMULATE_VERSION_MAJOR | ||
| char const info_simulate_version[] = { | ||
| 'I', 'N', 'F', 'O', ':', | ||
| 's','i','m','u','l','a','t','e','_','v','e','r','s','i','o','n','[', |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing space after , [whitespace/comma] [3]
[fixed] fixed a bug