Yuwenhao #43
Yuwenhao #43
Conversation
src/client/src/talker_client.cpp
Outdated
| #include "ros/ros.h" | ||
| #include "client/message.h" | ||
| #include "server/service.h" | ||
| #include <string> |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Found C++ system header after other header. Should be: talker_client.h, c system, c++ system, other. [build/include_order] [4]
src/client/src/talker_client.cpp
Outdated
| #include "client/message.h" | ||
| #include "server/service.h" | ||
| #include <string> | ||
| #include <signal.h> |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Found C system header after other header. Should be: talker_client.h, c system, c++ system, other. [build/include_order] [4]
src/client/src/talker_client.cpp
Outdated
|
|
||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
src/server/src/listener_server.cpp
Outdated
| #include "ros/ros.h" | ||
| #include "server/service.h" | ||
| #include "client/message.h" | ||
| #include <string> |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Found C++ system header after other header. Should be: listener_server.h, c system, c++ system, other. [build/include_order] [4]
src/server/src/listener_server.cpp
Outdated
| ros::spin(); | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
src/client/src/talker_client.cpp
Outdated
| @@ -0,0 +1,42 @@ | |||
| #include <string> | |||
| #include <signal.h> | |||
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Found C system header after C++ system header. Should be: talker_client.h, c system, c++ system, other. [build/include_order] [4]
src/client/src/talker_client.cpp
Outdated
| } | ||
| ROS_INFO("shutting down!"); | ||
| ros::NodeHandle nh; | ||
| ros::ServiceClient client_shut = nh.serviceClient<server::service>("service"); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Lines should be <= 80 characters long [whitespace/line_length] [2]
| client.call(srv2); | ||
| ros::shutdown(); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
| ros::ServiceServer service = n.advertiseService("service", SeekTopic); | ||
| ros::spin(); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
| srv2.request.status = 0; | ||
| client.call(srv2); | ||
| ros::shutdown(); | ||
|
|
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
| ros::shutdown(); | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
| ros::ServiceServer service = n.advertiseService("service", SeekTopic); | ||
| ros::spin(); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
| srv1.request.name = name; | ||
| srv1.request.status = 1; | ||
| client_set.call(srv1); | ||
| ros::Publisher chatter_pub = n.advertise<client::message>(name, 1000); |
基本功能完成