Layout fixes #132
Merged
Layout fixes #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit virtually eliminates the need to use size hint constraints on a container. A child container now contributes constraints to its parent concerning its minimum and maximum size. This makes nested containers work the same with and without the shared_layout flag, provided constraints dont cross container boundaries.
This forces the dock item to expand when docked, irrespective of dock widget's constraints. This is the only really sane behavior since the dock area should alway be filled.
This updates the min/max size handling to only update the sizes of the widget when it's ancestor is not a container. When it has an ancestor container, the ancestor layout manager must be the ultimate authority on min/max size, not the toolkit.
the settings for size hint are no longer needed with the new layout updates.
this tweaks the size hint constraints and default constraints for the task dialogs so that they continue to have the same user-facing layout behavior when run against the new layout updates.
this adds support to the layout manager to support boundary constraints on a widget in addition to size hint constraints
provide reasoning for disable a container's size hint constraints by default.
this as a resist_width declaration to the nested container so that it behaves like the fluid example with respect to initial window size.
|
This updates the layout system to be more natural and consistent with respect to sizing of nested containers and dealing with intrinsic minimum and maximum sizes. This requires minor updates to user's layout code in certain cases where the previous implicit semantics of container layout no longer apply. All of the examples have been updated and tested to reflect the new semantics. In general, this allowed the removal of a lot of unnecessary code in the examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.