Skip to content

Commit

Permalink
Merge pull request #15 from harlanj/master
Browse files Browse the repository at this point in the history
Move assert function to common.js file in test dir
  • Loading branch information
creationix committed Aug 23, 2016
2 parents bdf9c5a + 7b276f9 commit fcc3d6c
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 48 deletions.
6 changes: 6 additions & 0 deletions test/parallel/common/assert.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
function assert(thing, message) {
if (thing) return;
throw new Error(message);
}

return assert
7 changes: 1 addition & 6 deletions test/parallel/test-nucleus-compile.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@

function assert(thing, message) {
if (thing) return

throw new Error(message)
}
var assert = nucleus.dofile("./common/assert.js")

var a = nucleus.compile("'a'", 'a')
assert(a() === 'a', "compile should return 'a'")
Expand Down
7 changes: 1 addition & 6 deletions test/parallel/test-nucleus-dofile.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@

function assert(thing, message) {
if (thing) return

throw new Error(message)
}
var assert = nucleus.dofile("./common/assert.js")

assert(nucleus.dofile("../fixtures/a.js") === 'a', "a.js should expose 'a'")
27 changes: 11 additions & 16 deletions test/parallel/test-nucleus-get-set-env.js
Original file line number Diff line number Diff line change
@@ -1,36 +1,31 @@

function assert(thing, message) {
if (thing) return

throw new Error(message)
}
var assert = nucleus.dofile("./common/assert.js")

// get non-existing
assert(nucleus.getenv('__NUCLEUS_TEST') === null)
assert(nucleus.getenv('__NUCLEUS_TEST') === null, 'nonexisting env var should be `null`')

// set new
assert(nucleus.setenv('__NUCLEUS_TEST', 'nice day @nodeconf') === undefined)
assert(nucleus.setenv('__NUCLEUS_TEST', 'nice day @nodeconf') === undefined, 'setenv should return `undefined`')

// get newly set
assert(nucleus.getenv('__NUCLEUS_TEST') === 'nice day @nodeconf')
assert(nucleus.getenv('__NUCLEUS_TEST') === 'nice day @nodeconf', 'getenv should return value')

// newly set in envkeys
assert(nucleus.envkeys().indexOf('__NUCLEUS_TEST') !== -1)
assert(nucleus.envkeys().indexOf('__NUCLEUS_TEST') !== -1, 'env variable should be set in envkeys')

// re-set
assert(nucleus.setenv('__NUCLEUS_TEST', 'hi there') === undefined)
assert(nucleus.setenv('__NUCLEUS_TEST', 'hi there') === undefined, 'setenv should return `undefined`')

// get re-set
assert(nucleus.getenv('__NUCLEUS_TEST') === 'hi there')
assert(nucleus.getenv('__NUCLEUS_TEST') === 'hi there', 'get existing key should return `hi there`')

// re-set in envkeys
assert(nucleus.envkeys().indexOf('__NUCLEUS_TEST') !== -1)
assert(nucleus.envkeys().indexOf('__NUCLEUS_TEST') !== -1, 'env variable should be set in envkeys')

// unset
assert(nucleus.unsetenv('__NUCLEUS_TEST') === undefined)
assert(nucleus.unsetenv('__NUCLEUS_TEST') === undefined, 'setenv should return `undefined`')

// get now non-existing
assert(nucleus.getenv('__NUCLEUS_TEST') === null)
assert(nucleus.getenv('__NUCLEUS_TEST') === null, 'nonexisting env var should be `null`')

// no longer in envkeys
assert(nucleus.envkeys().indexOf('__NUCLEUS_TEST') === -1)
assert(nucleus.envkeys().indexOf('__NUCLEUS_TEST') === -1, 'env variable should be set in envkeys')
6 changes: 1 addition & 5 deletions test/parallel/test-nucleus-pathjoin.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
function assert(thing, message) {
if (thing) return

throw new Error(message)
}
var assert = nucleus.dofile("./common/assert.js")

assert(nucleus.pathjoin('a', 'b', 'c') === 'a/b/c', 'pathjoin must work')
6 changes: 1 addition & 5 deletions test/parallel/test-nucleus-readfile.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
function assert(thing, message) {
if (thing) return

throw new Error(message)
}
var assert = nucleus.dofile("./common/assert.js")

assert(nucleus.readfile('../fixtures/a.js') === "'a'\n", 'a.js must return it\'s raw source')

Expand Down
6 changes: 1 addition & 5 deletions test/parallel/test-nucleus-scandir.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
function assert(thing, message) {
if (thing) return

throw new Error(message)
}
var assert = nucleus.dofile("./common/assert.js")

var directory = nucleus.scandir('../fixtures', dirOnEntry)
assert(directory === true, 'scandir must see `fixtures` as a directory')
Expand Down
6 changes: 1 addition & 5 deletions test/parallel/test-nucleus.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
// var p = nucleus.dofile("deps/utils.js").prettyPrint;
// p(p);

function assert(thing, message) {
if (thing) return

throw new Error(message)
}
var assert = nucleus.dofile("./common/assert.js")

// Make sure nucleus is an object
assert(nucleus && typeof nucleus === 'object', '`nucleus` is not an Object')
Expand Down

0 comments on commit fcc3d6c

Please sign in to comment.