Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement duktape version using rust as glue code. #10

Closed
creationix opened this issue Jun 8, 2016 · 12 comments
Closed

Re-implement duktape version using rust as glue code. #10

creationix opened this issue Jun 8, 2016 · 12 comments

Comments

@creationix
Copy link
Member

creationix commented Jun 8, 2016

https://twitter.com/creationix/status/740367352533909504

@yoshuawuyts
Copy link

yoshuawuyts commented Jun 8, 2016

Omg yes! - This gets me mad excited

@fzzzy
Copy link

fzzzy commented Jun 12, 2016

Will this work occur on a branch?

@fzzzy
Copy link

fzzzy commented Jun 12, 2016

I see that there is already rust code in master.

@creationix
Copy link
Member Author

So I think these are the next steps. If anyone knows of a better plan of attack, let's talk about it.

  1. Replace miniz with a rust library and finally finish/fix zip writing from the binary.
  2. Replace read_from_zip, scan_from_zip, read_from_file, scan_from_file with rust.
  3. Replace main.c with main.rs by using existing duktape and libuv bindings for rust.

Step 3 is large and will obsolete half the code written in 1 and 2, so should we just jump straight to it?

@Fishrock123
Copy link
Member

@creationix Sounds like we should do number 3 first.

@creationix
Copy link
Member Author

creationix commented Jun 13, 2016

I've been doing some research. There are existing duktape and libuv bindings for rust already on crates.io, but they are not complete or updated recently.

I guess the next step is to write (or update/finish) rust bindings for the two languages. And start this as part of step 3 using our app as a way to manually test the integration.

@ashleygwilliams
Copy link
Collaborator

sounds like a good plan! a smaller first step is to get set up with cargo so that we're using rust via crates. thinking i might tackle that- thoughts?

@creationix
Copy link
Member Author

I'll start a new implementation that's started as a rust bin. We can leave the mostly C folder alone for now.

@creationix
Copy link
Member Author

I just added the rusty-duktape version. The main is just the sample from the getopts docs. A first step would be fixing that to use the nucleus CLI interface.

@creationix
Copy link
Member Author

#20

@creationix
Copy link
Member Author

Depends on #24 and #24

@Fishrock123
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants