Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick/neos 1034 update postgres constraint queries to not use information schema #1829

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

linear bot commented Apr 24, 2024

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 8:46pm
neosync-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 8:46pm

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 18.01242% with 132 lines in your changes are missing coverage. Please review.

Project coverage is 17.28%. Comparing base (ceac744) to head (9ef6dc0).
Report is 3 commits behind head on main.

Files Patch % Lines
backend/pkg/dbschemas/postgres/postgres.go 19.78% 71 Missing and 2 partials ⚠️
backend/pkg/sqlmanager/postgres-manager.go 0.00% 26 Missing ⚠️
...ckend/gen/go/db/dbschemas/postgresql/system.sql.go 0.00% 20 Missing ⚠️
cli/internal/cmds/neosync/sync/sync.go 0.00% 7 Missing ⚠️
...1alpha1/connection-data-service/connection-data.go 63.63% 1 Missing and 3 partials ⚠️
...run-sql-init-table-stmts/init-statement-builder.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
+ Coverage   17.24%   17.28%   +0.03%     
==========================================
  Files         215      215              
  Lines       45064    45052      -12     
==========================================
+ Hits         7773     7786      +13     
+ Misses      36332    36302      -30     
- Partials      959      964       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review April 24, 2024 20:45
@nickzelei nickzelei changed the title Nick/neos 1034 update constraint queries to not use information schema Nick/neos 1034 update postgres constraint queries to not use information schema Apr 24, 2024
@alishakawaguchi alishakawaguchi merged commit 2274442 into main Apr 24, 2024
15 checks passed
@alishakawaguchi alishakawaguchi deleted the nick/neos-1034-update-constraint-queries-to-not-use-information_schema branch April 24, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants