Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create job error message #936

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

alishakawaguchi
Copy link
Contributor

No description provided.

@alishakawaguchi alishakawaguchi self-assigned this Dec 20, 2023
Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview Dec 20, 2023 7:51pm

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9e00707) 60.78% compared to head (42b808a) 58.82%.

Files Patch % Lines
backend/services/mgmt/v1alpha1/job-service/jobs.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   60.78%   58.82%   -1.96%     
==========================================
  Files          82       38      -44     
  Lines        7966     4306    -3660     
==========================================
- Hits         4842     2533    -2309     
+ Misses       2551     1438    -1113     
+ Partials      573      335     -238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alishakawaguchi alishakawaguchi merged commit a6e972e into main Dec 20, 2023
7 of 9 checks passed
@alishakawaguchi alishakawaguchi deleted the alisha/neos-463-error-handling branch December 20, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant