Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert global merge scheduler #1937

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Revert global merge scheduler #1937

merged 3 commits into from
Mar 13, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Mar 13, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@lferran lferran changed the title Revert segment merger Revert global merge scheduler Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.88%. Comparing base (39b0fb6) to head (e941f20).

❗ Current head e941f20 differs from pull request most recent head 1fc4271. Consider uploading reports for the commit 1fc4271 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1937   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files         328      328           
  Lines       18611    18611           
=======================================
  Hits        15612    15612           
  Misses       2999     2999           
Flag Coverage Δ
ingest 68.72% <ø> (ø)
utils 81.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 0f33024 into main Mar 13, 2024
71 of 74 checks passed
@lferran lferran deleted the revert-segment-merger branch March 13, 2024 12:26
hermeGarcia added a commit that referenced this pull request Mar 13, 2024
hermeGarcia added a commit that referenced this pull request Mar 18, 2024
* rebase

* as version 2

* version 1 should not collect gc that often
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants