Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor datamanager usage to be consistent #1974

Merged
merged 5 commits into from
Mar 20, 2024
Merged

refactor datamanager usage to be consistent #1974

merged 5 commits into from
Mar 20, 2024

Conversation

vangheem
Copy link
Contributor

move txn management out of it for now

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 83.83%. Comparing base (ad37d53) to head (d333a7e).
Report is 2 commits behind head on main.

Files Patch % Lines
nucliadb/nucliadb/ingest/orm/knowledgebox.py 52.38% 10 Missing ⚠️
nucliadb/nucliadb/ingest/orm/processor/__init__.py 50.00% 1 Missing ⚠️
nucliadb/nucliadb/ingest/service/writer.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
- Coverage   83.98%   83.83%   -0.15%     
==========================================
  Files         329      328       -1     
  Lines       18681    18166     -515     
==========================================
- Hits        15689    15230     -459     
+ Misses       2992     2936      -56     
Flag Coverage Δ
ingest 68.71% <62.50%> (-0.09%) ⬇️
sdk 87.85% <ø> (ø)
utils 82.70% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangheem vangheem merged commit a147295 into main Mar 20, 2024
84 checks passed
@vangheem vangheem deleted the dm-refactor branch March 20, 2024 19:33
Copy link

sentry-io bot commented Mar 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Exception: [/usr/local/cargo/git/checkouts/client-rust-5a1ccd35a54db20f/eb1d2da/tikv-client-pd/src/timestamp... nucliadb.search.api.v1.chat.chat_knowledgebox_e... View Issue
  • ‼️ Exception: gRPC error: RpcFailure: 14-UNAVAILABLE upstream connect error or disconnect/reset before headers.... nucliadb.search.api.v1.knowledgebox.knowledgebo... View Issue
  • ‼️ TimeoutError: gRPC error: RpcFailure: 4-DEADLINE_EXCEEDED Deadline Exceeded nucliadb.search.api.v1.search.search_knowledgebox View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants