Switch to argdantic #2163
Switch to argdantic #2163
Conversation
javitonino
force-pushed
the
pydantic-argparse
branch
3 times, most recently
from
6386d9e
to
1103577
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 80c4a02 | Previous: 7a0c806 | Ratio |
|---|---|---|---|
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error |
12735.117647843901 iter/sec (stddev: 1.6383409268796183e-7) |
13028.091115305282 iter/sec (stddev: 9.732238981112996e-8) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
| prog="NucliaDB Datasets", | ||
| description="Generate Arrow files from NucliaDB KBs", |
There was a problem hiding this comment.
nit: can you migrate the descriptions/prog?
There was a problem hiding this comment.
I tried with the program name and it doesn't change anything in argdantic output. The description does, so I'll copy that.
javitonino
force-pushed
the
pydantic-argparse
branch
from
1103577
to
654abad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2163 +/- ##
==========================================
+ Coverage 76.22% 77.57% +1.34%
==========================================
Files 90 111 +21
Lines 6251 7375 +1124
==========================================
+ Hits 4765 5721 +956
- Misses 1486 1654 +168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
javitonino
force-pushed
the
pydantic-argparse
branch
2 times, most recently
from
1cf9412
to
af24746
Compare
javitonino
force-pushed
the
pydantic-argparse
branch
from
af24746
to
80c4a02
Compare
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.