Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused field types #2250

Merged
merged 11 commits into from
Jun 18, 2024
Merged

Remove unused field types #2250

merged 11 commits into from
Jun 18, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Jun 17, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 30fc9c9 Previous: 0d03d9f Ratio
tests/search/unit/search/test_fetch.py::test_highligh_error 2999.2657551580915 iter/sec (stddev: 0.000006698551811548005) 2841.0684406726436 iter/sec (stddev: 0.000004954958228416619) 0.95

This comment was automatically generated by workflow using github-action-benchmark.

@lferran lferran requested a review from a team June 17, 2024 07:51
@lferran lferran requested a review from jotare June 17, 2024 10:45
nucliadb_protos/resources.proto Outdated Show resolved Hide resolved
nucliadb_protos/writer.proto Show resolved Hide resolved
@lferran lferran merged commit 17d54bb into main Jun 18, 2024
54 checks passed
@lferran lferran deleted the remove-unused-fields2 branch June 18, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants