Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: convert search http exceptions to returns #736

Closed
wants to merge 2 commits into from
Closed

Conversation

vangheem
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 67.30% and project coverage change: -0.18 ⚠️

Comparison is base (865be1f) 82.20% compared to head (6739e06) 82.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   82.20%   82.02%   -0.18%     
==========================================
  Files         263      264       +1     
  Lines       15602    15656      +54     
==========================================
+ Hits        12825    12842      +17     
- Misses       2777     2814      +37     
Flag Coverage Δ
client 71.16% <ø> (ø)
ingest 64.41% <ø> (+0.06%) ⬆️
nucliadb 61.43% <67.30%> (-0.18%) ⬇️
reader 73.76% <ø> (ø)
sdk 70.04% <ø> (ø)
train 57.56% <ø> (ø)
utils 86.34% <ø> (ø)
writer 85.41% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nucliadb/nucliadb/search/api/v1/knowledgebox.py 73.46% <40.00%> (-2.07%) ⬇️
nucliadb/nucliadb/search/api/v1/chat.py 39.62% <50.00%> (-0.38%) ⬇️
nucliadb/nucliadb/search/api/v1/find.py 76.36% <50.00%> (-5.64%) ⬇️
nucliadb/nucliadb/search/api/v1/search.py 91.04% <69.23%> (-5.39%) ⬇️
nucliadb/nucliadb/search/api/v1/resource.py 93.33% <75.00%> (-3.22%) ⬇️
nucliadb/nucliadb/models/responses.py 100.00% <100.00%> (+13.33%) ⬆️
nucliadb/nucliadb/search/api/v1/exceptions.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vangheem
Copy link
Contributor Author

closing as not important right now and there's already been work done here.

@vangheem vangheem closed this Apr 11, 2023
@javitonino javitonino deleted the search-exc branch June 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant