Add an ingress for the dashboard in the Helm chart #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-prudhomme
changed the title
|
@sebastien-prudhomme Thanks! Looks great. We'll give it a spin and merge it. |
bivas
reviewed
Jul 28, 2019
|
Thank you @sebastien-prudhomme for this contribution :) |
liranbg
pushed a commit
that referenced
this pull request
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small PR to enable users to add an ingress for the dashboard.
I've used the "best practice" way for creating the ingress resource, that is the way the ingress is created when you do a
helm create mychart.I've also tried to copy the practices used in the nuclio helm chart for the labels and the directory structure.