Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard - allow using invocation urls from UI test pane #2181

Merged
merged 7 commits into from
Apr 27, 2021
Merged

Dashboard - allow using invocation urls from UI test pane #2181

merged 7 commits into from
Apr 27, 2021

Conversation

liranbg
Copy link
Contributor

@liranbg liranbg commented Apr 27, 2021 •
edited
Loading

To support function invocation from the UI for all sort of function invocation urls, I added x-nuclio-invoke-url whereas the UI can explicitly tell the nuclio-dashboard which incaotion url to use while invoking it.

  1. This url would be checked against the function status invocation urls
  2. If header is empty, it fallback to default behavior (where it uses x-nuclio-invoke-via)

omesser
omesser suggested changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@omesser omesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! super minor

cmd/dashboard/README.md Outdated Show resolved Hide resolved
pkg/platform/abstract/invoker.go Outdated Show resolved Hide resolved
@liranbg liranbg merged commit 90db48e into nuclio:development Apr 27, 2021
@liranbg liranbg deleted the nuclio-invoke-url branch April 27, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omesser omesser omesser requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liranbg @omesser