Fix bug where we get more than one message in a chunk #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavius
reviewed
Jul 12, 2018
| @@ -58,13 +58,18 @@ def __init__(self, | |||
| self.version = version | |||
|
|
|||
| def to_json(self): | |||
| return json.dumps(self, default=lambda o: o.__dict__) | |||
| obj = vars(self).copy() | |||
There was a problem hiding this comment.
Why? I imagine this affects performance
There was a problem hiding this comment.
It's actually a bit faster:
New version
In [1]: from event import Event
In [2]: e = Event()
In [5]: %timeit e.to_json()
4.8 µs ± 9.46 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
Old version
In [1]: from event import Event
In [2]: e = Event()
In [3]: %timeit e.to_json()
6.15 µs ± 22 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
However the main reason was that make test-python failed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.